Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Fail to process all bond callbacks in bondpy #96

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

sosoeeee
Copy link
Contributor

@sosoeeee sosoeeee commented Jul 2, 2024

I am currently using bondpy to create a Python lifecycle node as part of my development with the nav2 lifecycle manager. While the bond is formed successfully using bondpy, I encountered an issue where the node quickly dies due to a heartbeat timeout. After investigation, I discovered that bondpy fails to respond to all bond_status messages published by the lifecycle manager at high speed.

To resolve this issue, I referred to the implementation of bondcpp and increased the message buffer size from 1 to 100 in bondpy.

@sosoeeee sosoeeee requested a review from gbiggs as a code owner July 2, 2024 14:35
@RamanaBotta
Copy link

It worked for me.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this one on the latest release. This looks good to me, I'll go ahead and merge it.

@clalancette clalancette merged commit ff6ed3c into ros:ros2 Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants